Skip to content

Update to repo-config v0.13 #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2025
Merged

Update to repo-config v0.13 #398

merged 6 commits into from
Apr 8, 2025

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Mar 31, 2025

No description provided.

@llucax llucax requested a review from a team as a code owner March 31, 2025 14:10
@llucax llucax requested a review from Marenz March 31, 2025 14:10
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Mar 31, 2025
@llucax llucax self-assigned this Mar 31, 2025
@llucax llucax added this to the v1.7.0 milestone Mar 31, 2025
@llucax llucax enabled auto-merge March 31, 2025 14:11
@llucax
Copy link
Contributor Author

llucax commented Mar 31, 2025

Once this is approved, we need to update the branch protection rules to use the new required checks.

@llucax llucax requested a review from shsms April 1, 2025 12:13
@llucax
Copy link
Contributor Author

llucax commented Apr 1, 2025 •
edited
Loading

Already updated the rules.

@llucax llucax disabled auto-merge April 1, 2025 14:01
@llucax llucax enabled auto-merge April 1, 2025 14:02
Marenz
Marenz previously approved these changes Apr 1, 2025
View reviewed changes
@llucax llucax added this pull request to the merge queue Apr 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025
@llucax llucax force-pushed the repo-config-0.13 branch from 6c8c723 to d5b1ad4 Compare April 3, 2025 10:35
@llucax llucax enabled auto-merge April 3, 2025 10:39
@llucax
Copy link
Contributor Author

llucax commented Apr 3, 2025

The tests failed in the queue because of some unclosed socket that seem to come from hypothesis, I guess only because now we are treating warnings as errors in pytest. Re-triggering the job succeeded though. I hope we are not introducing a flaky test on arm, but if we are and it is just a warning, we can also roll-back the warnings-as-errors change until hypothesis is fixed.

I rebased so this needs a new approval @Marenz

@Marenz
Copy link
Contributor

Marenz commented Apr 3, 2025

It looks like you need to rebase this again

llucax added 5 commits April 3, 2025 14:30
@llucax
Migrate files to repo-config 0.12
5b30b0b 
Run the migration script from repo-config 0.12.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Fix a few tests warnings
5f83317 
Fix some deprecation warnings while overriding the event loop and for
`test_timer_intergration` we also use async-solipsism properly,
before we were not replacing the loop policy appropriately.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Update to repo-config v0.13.1
bed4686 
Use the migration script. Also bump other related/needed dependencies.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Update release notes
90538c6 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax
Remove extra space
c64ac70 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax force-pushed the repo-config-0.13 branch from d5b1ad4 to c64ac70 Compare April 3, 2025 12:32
Marenz
Marenz previously approved these changes Apr 3, 2025
View reviewed changes
@llucax llucax added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025
@llucax llucax added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@llucax llucax added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@llucax
Copy link
Contributor Author

llucax commented Apr 8, 2025

Added a new commit to filter-out the warning that is making the test fail in the merge queue. I also created an issue for this:

Needs new approval @Marenz

@llucax llucax requested a review from Marenz April 8, 2025 10:08
@llucax llucax enabled auto-merge April 8, 2025 10:08
@llucax llucax force-pushed the repo-config-0.13 branch from d13cfd6 to 6368b61 Compare April 8, 2025 12:51
@llucax llucax added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Apr 8, 2025
@llucax
Filter a warning we can't get rid of
e99dd52 
Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax force-pushed the repo-config-0.13 branch from 6368b61 to e99dd52 Compare April 8, 2025 13:15
@llucax llucax added this pull request to the merge queue Apr 8, 2025
Merged via the queue into frequenz-floss:v1.x.x with commit c4f8acd Apr 8, 2025
5 checks passed
@llucax llucax deleted the repo-config-0.13 branch April 8, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shsms shsms shsms approved these changes

@Marenz Marenz Awaiting requested review from Marenz

Assignees

@llucax llucax

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@llucax @Marenz @shsms